Major Android Revamp [Wifi Only] by daadu · Pull Request #88 · flutternetwork/WiFiFlutter

daadu · 2020-10-29T05:00:06Z

Picking up with changes in Flutter (Android side) and Android SDK

TODO

Note for tester/reviewers

All the changes should be backward compatible, ie. should work with all flutter app as it is by just upgrading the package version. There for I encourage the reviewer to test both scenarios (>=29 and < 29; embedding v1 and v2).

To test this branch use the following in dependencies in puspec.yaml of your app:

dependencies:
  wifi_iot:
    git: 
      url: https://github.com/daadu/WiFiFlutter.git
      ref: android-major-revamp

This PR should potentially resolve following issues:

…WithContext` and `initWithActivity` method; added `cleanup` method - [WifiIotPlugin] added `FlutterPlugin` and `ActivityAware` interfaces and override associated methods

- [example,android] upgraded `compileSDKVersion` to 29 and build tool to `4.1.0` and gradle to `6.5` - [example,android] migrated to androidx - [flutter] `pubspec.lock` upgraded

- [android] removed `WifiConfiguration` from import since deprecated, using full class name instead - [android] `loadWifiList`: only calling `WifiManager.startScan` for API < 28 - [readme] added warning (5) for "Enabling / Disabling WiFi module" for android platform

…ted`, implemented latest APIs for connecting - [readme] added warning for WEP deprecation for android platform

Niek · 2020-10-29T10:05:06Z

Great work @daadu! I tested your branch and it works fine, no errors or issues in the functions that we use: loadWifiList() and connect()/disconnect().

BTW there's a new official plugin that offers some "info" functions: https://github.com/flutter/plugins/tree/master/packages/wifi_info_flutter/wifi_info_flutter

daadu · 2020-10-29T10:33:39Z

Great work @daadu! I tested your branch and it works fine, no errors or issues in the functions that we use: loadWifiList() and connect()/disconnect().

did you test with both sets: Android SDK >=29 and < 29; Android Embedding v1 and v2?

BTW there's a new official plugin that offers some "info" functions: https://github.com/flutter/plugins/tree/master/packages/wifi_info_flutter/wifi_info_flutter

Will think of add this once the mammoth is dealt with!

…xample app - [android] `isConnected`: moved old logic to `isConnectedDeprecated` and implemented with new APIs

daadu · 2020-10-29T12:09:06Z

@Alternadom sudoForResult, readFully, Closer methods/classes where unused, I have removed. Are they of any use?

…android.permission.ACCESS_FINE_LOCATION`

…ilable` - [android] `disconnect`: added new SDK implementations

…error for SDK >= 29 - [readme] added warning for Registering/Unregistering an Wifi Network - [readme] added warning for Connecting/Disconnecting on a network

daadu · 2020-11-03T06:32:33Z

Seems like Access Point methods are complicated using "mirrors" (hidden API) and there has been no issue raised for AP, hence this PR will not cover it.

There for #83 is out of scope of this PR.

daadu · 2020-11-03T06:42:18Z

@Niek @krishnaaro Please test and review this.

daadu · 2020-11-03T06:55:45Z

unlinking #78 since AP is out of scope of this PR

…cm.getActiveNetwork`, since it was returning network only when internet was present

daadu · 2020-11-10T13:07:24Z

@Alternadom This PR LGTM.

Just to be safe can we release this as "alpa" on pub.dev, and then maybe after few weeks push to main version. I was thinking something like 1.1.2-alpha.0 for now.

daadu · 2020-11-12T11:10:56Z

Although I found it later, this article/post is a good resource that explains and clarifies the new APIs.

Niek · 2020-11-19T09:30:21Z

Thanks for the amazing work @daadu! Is this ready for merging yet?

daadu · 2020-11-19T11:20:13Z

Thanks for the amazing work @daadu! Is this ready for merging yet?

Your welcome @Niek. It LGTM for merging, as mentioned before, would like if this changes are released as "alpha" (something like v1.1.2-alpha.0) before proper release with v1.1.2

Niek · 2020-11-19T13:05:44Z

Great, I do see one exception when changing target SDK to 30, but not sure if it's coming from this plugin:

W/ConnectionTracker(21779): Exception thrown while unbinding
W/ConnectionTracker(21779): java.lang.IllegalArgumentException: Service not registered: lp@3865763
W/ConnectionTracker(21779):     at android.app.LoadedApk.forgetServiceDispatcher(Unknown Source:195)
W/ConnectionTracker(21779):     at android.app.ContextImpl.unbindService(Unknown Source:11)
W/ConnectionTracker(21779):     at android.content.ContextWrapper.unbindService(Unknown Source:2)
W/ConnectionTracker(21779):     at ci.f(:com.google.android.gms.dynamite_measurementdynamite@204217081@20.42.17 (120400-0):1)
W/ConnectionTracker(21779):     at ci.d(:com.google.android.gms.dynamite_measurementdynamite@204217081@20.42.17 (120400-0):2)
W/ConnectionTracker(21779):     at lq.D(:com.google.android.gms.dynamite_measurementdynamite@204217081@20.42.17 (120400-0):10)
W/ConnectionTracker(21779):     at lc.a(:com.google.android.gms.dynamite_measurementdynamite@204217081@20.42.17 (120400-0):2)
W/ConnectionTracker(21779):     at ee.run(:com.google.android.gms.dynamite_measurementdynamite@204217081@20.42.17 (120400-0):3)
W/ConnectionTracker(21779):     at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:462)
W/ConnectionTracker(21779):     at java.util.concurrent.FutureTask.run(FutureTask.java:266)
W/ConnectionTracker(21779):     at ix.run(:com.google.android.gms.dynamite_measurementdynamite@204217081@20.42.17 (120400-0):6)

daadu · 2020-11-19T14:37:02Z

@Niek Android SDK 30 (flutter/engine#20479) is not still supported by flutter engine in stable channel. Although it has been merged with master, so could be available master or dev.

Try with 29 and/or change the flutter channel and test with 30.

daadu · 2020-11-19T14:40:34Z

@Niek Also did the functionality worked (disrespect of the logs)?

daadu · 2020-11-19T14:42:43Z

@Niek Also the error looks like firebase plugin issue [ firebase/firebase-android-sdk#1662 ]

daadu · 2020-11-19T14:48:08Z

@Niek Looks like firebase is not ready for v30!!

daadu · 2020-11-21T04:35:20Z

#85 reported issue with internet connectivity after connecting to wifi.

Major Android Revamp [Wifi Only]

- [WifiIotPlugin] removed private constructor and replaces with `init…

8cd7ee7

…WithContext` and `initWithActivity` method; added `cleanup` method - [WifiIotPlugin] added `FlutterPlugin` and `ActivityAware` interfaces and override associated methods

daadu requested a review from florian-guillemard October 29, 2020 05:00

daadu self-assigned this Oct 29, 2020

daadu removed a link to an issue Oct 29, 2020

获取wifi列表需要开启GPS才能正常得到 You need to turn on GPS to get WiFi list。Why？ #70

Closed

daadu linked an issue Oct 29, 2020 that may be closed by this pull request

doesnt work on android versions 8 and above #78

Closed

daadu added 3 commits October 29, 2020 10:48

- [android] upgraded compileSDKVersion to 29 and build tool to 4.1.0

cc031e4

- [example,android] upgraded `compileSDKVersion` to 29 and build tool to `4.1.0` and gradle to `6.5` - [example,android] migrated to androidx - [flutter] `pubspec.lock` upgraded

- [android] connectTo: moved all current logic to `connectToDepreca…

19d9905

…ted`, implemented latest APIs for connecting - [readme] added warning for WEP deprecation for android platform

daadu added 2 commits October 29, 2020 16:21

- [android] upgraded to compile and target SDK to 30 for plugin and e…

84c528b

…xample app - [android] `isConnected`: moved old logic to `isConnectedDeprecated` and implemented with new APIs

[android] removed NetworkInfo from imports

220931e

This was referenced Oct 29, 2020

Doesn't work with Android targetSdk 29 #60

Closed

doesnt work on android versions 8 and above #78

Closed

WiFiForIoTPlugin.connect always returns false #80

Closed

WifiIotPlugin.java uses or overrides a deprecated API. #83

Open

daadu removed a link to an issue Oct 29, 2020

Can't get Wifi Access Point Infos in android version 8.0.0 and 9 #84

Closed

daadu mentioned this pull request Oct 29, 2020

findAndConnect returns FALSE in android 10 #85

Closed

[android] removed sudoForResult, readFully, Closer

18d8905

daadu added 3 commits October 30, 2020 16:49

[android] replaced android.permission.ACCESS_COARSE_LOCATION with `…

c2f5f46

…android.permission.ACCESS_FINE_LOCATION`

- [android] fix connectTo: removed unregister request inside `onAva…

5ccad4b

…ilable` - [android] `disconnect`: added new SDK implementations

- [android] removeWifiNetwork and isRegisteredWifiNetwork: added …

dcdb3b1

…error for SDK >= 29 - [readme] added warning for Registering/Unregistering an Wifi Network - [readme] added warning for Connecting/Disconnecting on a network

daadu removed a link to an issue Nov 3, 2020

WifiIotPlugin.java uses or overrides a deprecated API. #83

Open

daadu marked this pull request as ready for review November 3, 2020 06:40

[readme] minor: ⚠️ instead of ❓ for 5,6,7

8ec7206

daadu removed a link to an issue Nov 3, 2020

doesnt work on android versions 8 and above #78

Closed

daadu changed the title ~~Major Android Revamp~~ Major Android Revamp [Wifi Only] Nov 3, 2020

daadu marked this pull request as draft November 3, 2020 07:24

[android] isConnected: fix - using cm.getAllNetworks instead of `…

c1f8295

…cm.getActiveNetwork`, since it was returning network only when internet was present

daadu marked this pull request as ready for review November 10, 2020 13:05

[readme] minor changes

11c84f2

florian-guillemard merged commit b177c40 into flutternetwork:master Nov 25, 2020

daadu deleted the android-major-revamp branch January 28, 2021 13:25

daadu mentioned this pull request Jan 30, 2021

showWritePermissionSettings unused/not visible? #111

Closed

daadu pushed a commit that referenced this pull request May 12, 2021

Merge pull request #88 from daadu/android-major-revamp

c350062

Major Android Revamp [Wifi Only]

Conversation

daadu commented Oct 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TODO

Note for tester/reviewers

Uh oh!

Niek commented Oct 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

daadu commented Oct 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

daadu commented Oct 29, 2020

Uh oh!

daadu commented Nov 3, 2020

Uh oh!

daadu commented Nov 3, 2020

Uh oh!

daadu commented Nov 3, 2020

Uh oh!

daadu commented Nov 10, 2020

Uh oh!

daadu commented Nov 12, 2020

Uh oh!

Niek commented Nov 19, 2020

Uh oh!

daadu commented Nov 19, 2020

Uh oh!

Niek commented Nov 19, 2020

Uh oh!

daadu commented Nov 19, 2020

Uh oh!

daadu commented Nov 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

daadu commented Nov 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

daadu commented Nov 19, 2020

Uh oh!

daadu commented Nov 21, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

daadu commented Oct 29, 2020 •

edited

Loading

Niek commented Oct 29, 2020 •

edited

Loading

daadu commented Oct 29, 2020 •

edited

Loading

daadu commented Nov 19, 2020 •

edited

Loading

daadu commented Nov 19, 2020 •

edited

Loading